Refactor startup command to wait for node IP changes #598
+137
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: galal-hussein <[email protected]>
Signed-off-by: galal-hussein <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
==========================================
- Coverage 59.02% 56.01% -3.02%
==========================================
Files 56 55 -1
Lines 5316 5297 -19
==========================================
- Hits 3138 2967 -171
- Misses 1893 2035 +142
- Partials 285 295 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: galal-hussein <[email protected]>
Signed-off-by: galal-hussein <[email protected]>
enrichman
reviewed
Jan 7, 2026
Collaborator
enrichman
left a comment
There was a problem hiding this comment.
Just a couple of minor nits, but looks good, thanks!
Signed-off-by: galal-hussein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the controller to update the node's address when the server pod restarts, this prevents issues like network policy controller starting and crashing due to changes in node IPThe PR refactors the startup command, now the startup command is divided into 3 functions:
1- single_server()
This simply when k3k starts a cluster with only one node, this has to be specially handled because if the server gets its IP changes (i.e pod deleted and restarted) then cluster quorum has to be resetted.
2- ha_server()
This is when a server starts in HA mode, and we check if its the first server to start then we start the server with init config, and if its other servers then we start with normal server config
3- safe_mode()
If the pod changes IP (server pod gets recreated) and since some services (like network policy controllers) requires the node IP to be correct see k3s-io/k3s#12844, then k3k needs to handle these situation, the current safe mode disables the network policy controller and starts a temporary server until the node IP is corrected by kubelet, once corrected we exit the safe mode gracefully allowing the pod to start normally.
Logs
These are example logs from different scenarios:
1- single server cluster pod being deleted and recreated:
2- HA 1st server pod gets deleted and recreated
3- HA second or third server pod gets deleted and recreated